71846[BUGFIX] Avoid php8.1 return type deprecations in LogRecord
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Gilli +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Gilli +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Stefan Bürk uploaded patch set 1 10/17/21, 17:02
-
core-ci voted on patch set 1 V +1 10/17/21, 17:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18253
-
Stefan Bürk commented on patch set 1 10/17/21, 19:03
I tried to add type hints were possible, and use the attribute where not. But I'm not sure if this "could" be breaking - because of lack of experience in that area. This would be nice if someone with experience could confirm that it is not breaking for instances. -
Stefan Bürk voted on patch set 1 CR -1 10/17/21, 19:07
-
Christian Kuhn uploaded patch set 2 10/17/21, 19:43
-
core-ci voted on patch set 2 V +1 10/17/21, 19:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18263
-
Christian Kuhn voted on patch set 2 V +1 CR +1 10/17/21, 20:01
-
Simon Gilli voted on patch set 2 V +1 CR +1 10/17/21, 20:11
-
Christian Kuhn voted on patch set 2 V +2 CR +2 10/17/21, 20:16
-
Christian Kuhn merged patch set 3 10/17/21, 20:16