Review main Merged

71848[BUGFIX] Avoid php8.1 return type deprecation for (Lazy)ObjectStorage

Stefan Bürk CR +2 V +2 Easy +30 −18 updated 10/18/21, 11:39

Commit message

This patch adds correct return types where possible,
otherwise add the #[\ReturnTypeWillChange] attribute
to temporarly silence the message for php8.1, but
keep 7.4 compatibility.

Added parentheses in `ObjectStorage::offsetSet()`
to ensure operation order for the future.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Stefan Bürk uploaded patch set 1 10/17/21, 17:47

  2. Stefan Bürk updated the commit message in patch set 2 10/17/21, 17:49

  3. Stefan Bürk commented on patch set 2 CR -1 10/17/21, 18:01

    I want here some one with more experience. I'm not sure it is really good to add the return type hints to the methods, meaning if that could be a breaking change for instances. So -1 from me for now on my own patch.
  4. core-ci voted on patch set 1 V -1 10/17/21, 18:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18255

  5. core-ci voted on patch set 2 V -1 10/17/21, 18:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18256

  6. Stefan Bürk uploaded patch set 3 10/17/21, 18:44

  7. core-ci voted on patch set 3 V +1 10/17/21, 19:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18260

  8. Stefan Bürk commented on patch set 3 10/17/21, 19:06

    I tried to add type hints were possible, and use the attribute where not. But I'm not sure if this "could" be breaking - because of lack of experience in that area. This would be nice if someone with experience could confirm that it is not breaking for instances.
  9. Stefan Bürk voted on patch set 3 CR -1 10/17/21, 19:07

  10. Stefan Bürk uploaded patch set 4 10/17/21, 20:04

  11. core-ci voted on patch set 4 V +1 10/17/21, 20:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18266

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 10/17/21, 20:44

  13. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/18/21, 08:16

  14. Wouter Wolters voted on patch set 4 CR +1 10/18/21, 09:21

  15. Oliver Klee voted on patch set 4 CR +1 10/18/21, 09:31

  16. Christian Kuhn voted on patch set 4 V +2 CR +2 10/18/21, 11:39

  17. Christian Kuhn merged patch set 5 10/18/21, 11:39