Review main Merged

71873[TASK] Avoid TYPO3_MODE definition in tests

Christian Kuhn CR +2 V +2 Easy +0 −4 updated 10/18/21, 11:38

Commit message

Constant TYPO3_MODE has been deprecated in v11.
It should not be defined for tests anymore.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Gilli +1
    • Guido Schmechel +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Gilli +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 910

  1. Christian Kuhn uploaded patch set 1 10/17/21, 22:29

  2. core-ci voted on patch set 1 V +1 10/17/21, 22:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18272

  3. Simon Gilli voted on patch set 1 V +1 CR +1 10/17/21, 22:52

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/18/21, 06:49

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 10/18/21, 07:06

  6. Guido Schmechel voted on patch set 1 CR +1 10/18/21, 08:03

  7. Wouter Wolters voted on patch set 1 V +1 CR +1 10/18/21, 09:15

  8. Oliver Klee voted on patch set 1 CR +1 10/18/21, 09:31

  9. Georg Ringer voted on patch set 1 V +2 CR +2 10/18/21, 11:38

  10. Georg Ringer merged patch set 2 10/18/21, 11:38