71875[BUGFIX] Use Collator->compare for proper sorting of TCA type select items
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 2029
Show 34 earlier messages
-
Jochen Roth uploaded patch set 1 10/18/21, 12:00
-
Georg Ringer commented on patch set 1 10/18/21, 12:07
-
core-ci voted on patch set 1 V +1 10/18/21, 12:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18278
-
Jochen Roth commented on patch set 1 10/18/21, 12:24
TcaSelectItems.php:293Reply> what if not set? If not set it falls back to environment variables. > Can we somehow use $this->getBackendUser()->user['lang'] because using the systemlocale doesn't really help with users with different languages does it? It will be different sorting depending on the users language. Not sure if this is a wanted behavior.
-
Jochen Roth uploaded patch set 2 10/19/21, 11:36
-
core-ci voted on patch set 2 V -1 10/19/21, 11:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18306
-
Stefan P commented on patch set 2 10/21/21, 06:50
TcaSelectItems.php:293Reply UnresolvedWell, the current implemenation that sorts wrongly also does not respect the current users language. The proposed patch is a bugfix for the current faulty behaviour. No reason to block it (if this missing feature would be a valid patch-block reason than this not-user-language-respecting feature shouldn't have made it in the core the first place). How can a missing feature that was not there at all, block a valid bugfix? Making it per-user would be a new feature, no bugfix. (these kind of discussion are a retarder for many improvements in the TYPO3 core, in the recent past) -
Jochen Roth uploaded patch set 3 10/22/21, 20:21
-
core-ci voted on patch set 3 V +1 10/22/21, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18430
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/23/21, 13:39
-
Jochen Roth updated the commit message in patch set 4 10/25/21, 08:11
-
core-ci voted on patch set 4 V +1 10/25/21, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18516
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/25/21, 08:29
-
Christian Kuhn commented on patch set 4 10/25/21, 16:28
this adds an implicit dependency to (default active) php-intl. we need to discuss if that is ok with v11. -
Christian Kuhn commented on patch set 4 CR -1 10/25/21, 16:29
postponed until php-intl has been decided on. -
Christian Kuhn uploaded patch set 5 10/25/21, 16:55
-
Christian Kuhn voted on patch set 5 CR -1 10/25/21, 16:55
-
core-ci voted on patch set 5 V -1 10/25/21, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18546
-
Christian Kuhn uploaded patch set 6 10/25/21, 17:03
-
Christian Kuhn voted on patch set 6 CR -1 10/25/21, 17:03
-
core-ci voted on patch set 6 V +1 10/25/21, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18547
-
Benni Mack commented on patch set 6 CR -1 11/04/21, 14:47
woudln't do this in 10.4 -
Jochen Roth uploaded patch set 7 11/04/21, 15:00
-
Jochen Roth uploaded patch set 8 11/04/21, 15:10
-
core-ci voted on patch set 8 V -1 11/04/21, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18897
-
core-ci voted on patch set 7 V -1 11/04/21, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18895
-
Jochen Roth uploaded patch set 9 11/04/21, 15:52
-
core-ci voted on patch set 9 V -1 11/04/21, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18905
-
Christian Kuhn abandoned the change 11/04/21, 16:35
abandoned for now, we may pick that up in v12 again.
TcaSelectItems.php:293