71877[BUGFIX] Use package information to list extensions in Extension Manager
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Oliver Hader +1
-
Verified V +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3139
Show 1014 earlier messages
-
Helmut Hummel uploaded patch set 1 10/18/21, 16:58
-
Simon Schaufelberger commented on patch set 1 10/18/21, 17:04
-
Simon Schaufelberger commented on patch set 1 10/18/21, 17:08
ListUtility.php:203Reply -
core-ci voted on patch set 1 V -1 10/18/21, 17:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18288
-
Stefan Bürk commented on patch set 1 10/18/21, 18:54
ListUtility.php:203ReplyThat would not work, as unpacking arrays with string keys are not allowed - as far as I know. That feature will be added with php8.1. Anyway phpstan complainet here in ci. Maybe use paranthese here (not nested, suggestion into the blue)? ``` $properties = array_merge((($emConf ?? [] ) ?: []), $properties); or if(!is_array($emConf ?? [])) { $emConf = []; } $properties = array_merge(($emConf ?? []), $properties); ``` -
Simon Gilli commented on patch set 1 V +1 10/18/21, 18:55
Thx, works like expected! -
Guido Schmechel updated the commit message in patch set 2 10/18/21, 19:32
-
core-ci voted on patch set 2 V -1 10/18/21, 19:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18290
-
Simon Gilli uploaded patch set 3 10/18/21, 22:24
-
Simon Gilli uploaded patch set 4 10/18/21, 22:26
-
Simon Gilli commented on patch set 4 10/18/21, 22:26
ListUtility.php:203ReplyThe issue is the phpdoc of includeEmConf() where array|bool is declared but array|false is returned. -
core-ci voted on patch set 3 V -1 10/18/21, 22:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18292
-
core-ci voted on patch set 4 V -1 10/18/21, 22:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18293
-
Simon Gilli uploaded patch set 5 10/19/21, 09:09
-
core-ci voted on patch set 5 V +1 10/19/21, 09:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18299
-
Simon Gilli voted on patch set 5 V +1 CR +1 10/19/21, 09:29
-
Stefan Bürk commented on patch set 5 10/19/21, 09:32
ListUtility.php:208Does that mean that version is always used from composer package information, even in legacy installs and extensions still having em_conf.php ? -
Oliver Hader commented on patch set 5 10/19/21, 09:35
The previously failing tests in `ListUtilityTest` reveal the architectural flaw - however it's fine for a quick fix. To migrate from `ext_emconf.php` to Composer-Manifest, probably a new adapter `ExtensionMetaData` would be nice which either takes data from Composer and/or `ext_emconf.php`. That way domain-specific meta-data for the concept of an "extension" would be bundled in one class.ListUtility.php:21PackageInterface? -
Helmut Hummel commented on patch set 5 10/19/21, 10:05
ListUtility.php:21ReplyAckListUtility.php:208ReplyIn legacy system the version information is pulled from em_conf.php by the PackageManager. This means using the PM API here means it is always the correct information: in legacy system it is from ext_emconf.php in Composer based systems it is the version installed by Composer -
Oliver Hader commented on patch set 5 10/19/21, 10:06
I'm on it... -
Helmut Hummel commented on patch set 5 10/19/21, 10:17
Reply
I would prefer to have the abstraction in the Package Factory (currently inside PackageManager), which already consolidates the information from either composer.json or ext_emconf.php or the Composer install process. -
Oliver Hader uploaded patch set 6 10/19/21, 11:25
-
Helmut Hummel commented on patch set 6 10/19/21, 11:30
ListUtility.php:206With this still in place, this would not fix the initial issue at all. Why do you think it is necessary to skip packages without emconf here? -
core-ci voted on patch set 6 V -1 10/19/21, 11:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18305
-
Helmut Hummel voted on patch set 6 CR -1 10/19/21, 11:44
-
Helmut Hummel commented on patch set 6 CR 0 10/19/21, 11:48
ListUtility.php:206Replynever mind. all fine here -
Helmut Hummel uploaded patch set 7 10/19/21, 11:55
-
Oliver Hader voted on patch set 7 V +1 CR +1 10/19/21, 11:58
-
core-ci voted on patch set 7 V +1 10/19/21, 12:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18307
-
Helmut Hummel uploaded patch set 8 10/19/21, 12:21
-
Simon Gilli commented on patch set 8 V -1 CR +1 10/19/21, 12:33
on it... -
Oliver Hader voted on patch set 8 V +1 CR +1 10/19/21, 12:33
-
core-ci voted on patch set 8 V +1 10/19/21, 12:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18308
-
Simon Gilli voted on patch set 8 V +1 10/19/21, 12:39
-
Helmut Hummel voted on patch set 8 V +2 CR +2 10/19/21, 12:41
-
Helmut Hummel merged patch set 9 10/19/21, 12:41
-
Stefan Bürk commented on patch set 9 01/19/22, 18:45
ListUtility.php:129$properties is undefined in this method - missed to retrieve it or should this be another variable - but I'm not into this all - or is this subfallback superflous ? -
Helmut Hummel commented on patch set 9 01/20/22, 11:49
ListUtility.php:129Reply"subfallback" can indeed be removed. str_starts_with($version, 'dev-') ? 'alpha' : 'stable' is fine (from reading) -
Stefan Bürk commented on patch set 9 01/20/22, 14:07
ListUtility.php:129ReplyDone (closing comment) -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/73104
ListUtility.php:203