Review main Merged

71878[BUGFIX] Ensure slug pieces are strings

Markus Klein CR +2 V +2 Easy +1 −1 updated 10/19/21, 14:13

Commit message

Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database driver the data type
may vary, so always cast them to string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Markus Klein uploaded patch set 1 10/18/21, 20:39

  2. core-ci voted on patch set 1 V +1 10/18/21, 20:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18291

  3. Mathias Brodala updated the commit message in patch set 2 10/19/21, 07:16

  4. Mathias Brodala voted on patch set 2 CR +1 10/19/21, 07:16

  5. core-ci voted on patch set 2 V +1 10/19/21, 07:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18297

  6. Oliver Klee voted on patch set 2 CR +1 10/19/21, 08:58

  7. Jochen Roth voted on patch set 2 V +1 CR +1 10/19/21, 14:12

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/19/21, 14:13

  9. Christian Kuhn merged patch set 3 10/19/21, 14:13