Review main Merged

71879[BUGFIX] Avoid warning from optional HTTP_ACCEPT_LANGUAGE HTTP header

Georg Ringer CR +2 V +2 Easy +1 −1 updated 10/19/21, 14:10

Commit message

'Accept-Language' may not be sent by clients, the patch sanitizes access
to $request HTTP_ACCEPT_LANGUAGE using null coalescing operator.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 10/19/21, 05:59

  2. Georg Ringer commented on patch set 1 10/19/21, 06:00

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/19/21, 06:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18296

  4. Oliver Klee voted on patch set 1 CR +1 10/19/21, 08:58

  5. Jochen Roth voted on patch set 1 V +1 CR +1 10/19/21, 14:09

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/19/21, 14:10

  7. Christian Kuhn merged patch set 2 10/19/21, 14:10