Review main Merged

71882[TASK] Avoid code duplication in splitFunctionalTests.php

Christian Kuhn CR +2 V +2 Normal +10 −70 updated 10/19/21, 12:04

Commit message

Build/Scripts/splitFunctionalTests.php is used in
gitlab-ci via runTests.sh to split functional tests
into smaller and better digestible chunks, so we can
run multiple jobs instead of one.

The script writes one xml file per job, which is
then picked up by phpunit runner.

It currently duplicates the basic xml setup from
Build/phpunit/FunctionalTests.xml.

The patch changes this to read existing .xml file
adds the files to be tested using an xml parser and
writes new xml files per job. This avoids the xml
setup duplication and is easier to maintain.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 10/19/21, 09:47

  2. Christian Kuhn updated the commit message in patch set 2 10/19/21, 09:49

  3. core-ci voted on patch set 1 V +1 10/19/21, 09:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18302

  4. core-ci voted on patch set 2 V +1 10/19/21, 10:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18303

  5. Stefan Bürk voted on patch set 2 CR +1 10/19/21, 11:28

  6. Stefan Bürk voted on patch set 2 V +1 10/19/21, 11:50

  7. Jochen Roth voted on patch set 2 V +1 CR +1 10/19/21, 12:03

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/19/21, 12:04

  9. Christian Kuhn merged patch set 3 10/19/21, 12:04