71885[BUGFIX] Keep hyphens when lexing words for indexed_search
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Tomas Norre Mikkelsen +1
-
Verified V +2 Done
- Benni Mack +2
- Tomas Norre Mikkelsen +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1418
-
Stephan Großberndt uploaded patch set 1 10/19/21, 13:38
-
Mathias Brodala commented on patch set 2 10/19/21, 13:40
Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 10/19/21, 14:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18315
-
core-ci voted on patch set 1 V +1 10/19/21, 14:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18313
-
Benni Mack commented on patch set 2 11/04/21, 11:18
Hyphens are also used to exclude a word in indexed search. Is this still respected? -
Benni Mack updated the commit message in patch set 3 11/18/21, 10:43
-
core-ci voted on patch set 3 V +1 11/18/21, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19458
-
Benni Mack wrote 11/29/21, 10:15
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 14:02
-
core-ci voted on patch set 4 V +1 11/29/21, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20079
-
Benni Mack commented on patch set 4 CR -1 12/23/21, 09:41
ping... I did not get an answer to my question here yet... -
Benni Mack commented on patch set 4 01/06/22, 14:36
ping again... -
Stephan Großberndt commented on patch set 4 01/06/22, 14:59
I don't know. I just took over this issue from https://github.com/TYPO3/typo3/pull/293 which was made against v9.5 and thus abandoned: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67617 -
Benni Mack commented on patch set 4 01/06/22, 15:01
OK. I think this contradicts the "-" (exclude a search word), thus: I wouldn't say we should support this for the time being until we rework the indexed search functionality. -
Tomas Norre Mikkelsen commented on patch set 4 V +1 CR +1 07/11/22, 10:12
I have tested this. The -ipsum, lorem-ipsum, +ipsum is still working, so looks like this is a valid solution without breaking existing functionality. -
Benni Mack voted on patch set 4 CR 0 07/11/22, 10:23
-
Benni Mack commented on patch set 4 V +2 CR +2 07/15/22, 14:12
Reply
Done -
Benni Mack merged patch set 5 07/15/22, 14:12