Review main Merged

71887[TASK] Add package type to meta data and use that to resolve type

Helmut Hummel CR +2 V +2 Easy +14 −12 updated 10/20/21, 08:00

Commit message

Instead of reading the composer.json of packages on runtime,
use the existing meta data API to store and retrieve this
information.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 67

  1. Helmut Hummel uploaded patch set 1 10/19/21, 14:59

  2. core-ci voted on patch set 1 V +1 10/19/21, 15:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18323

  3. Oliver Hader voted on patch set 1 CR +1 10/19/21, 16:01

  4. Oliver Hader voted on patch set 1 V +1 10/19/21, 16:10

  5. Wouter Wolters voted on patch set 1 V +1 CR +1 10/19/21, 20:17

  6. Helmut Hummel commented on patch set 1 V +2 CR +2 10/20/21, 08:00

    Thanks for the quick reviews!
  7. Helmut Hummel merged patch set 2 10/20/21, 08:00