71888[TASK] Add extension title to meta data and use it
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Command/ExtensionListCommand.php+3 −3
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php10+20 −0
- typo3/sysext/core/Classes/Package/MetaData.php+11 −1
- typo3/sysext/core/Classes/Package/Package.php+3 −6
- typo3/sysext/core/Classes/Package/PackageManager.php3+2 −0
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+1 −6
Review log 2227
Show 2 earlier messages
-
core-ci voted on patch set 2 V +1 10/19/21, 15:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18325
-
core-ci voted on patch set 1 V +1 10/19/21, 15:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18324
-
Helmut Hummel uploaded patch set 3 10/19/21, 20:46
-
core-ci voted on patch set 3 V +1 10/19/21, 21:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18348
-
Wouter Wolters commented on patch set 3 10/19/21, 21:14
PackageArtifactBuilder.php:110isn't it better to declare title before the if on 114? Is never used when getTitle() returns a correct value. -
Helmut Hummel commented on patch set 3 10/20/21, 08:10
PackageArtifactBuilder.php:104ReplyAckPackageArtifactBuilder.php:110ReplyDone -
Helmut Hummel uploaded patch set 4 10/20/21, 08:10
-
core-ci voted on patch set 4 V +1 10/20/21, 08:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18370
-
Simon Gilli commented on patch set 4 10/20/21, 09:48
PackageManager.php:898Do I get it right, the extra section finally looks like this? extra: { "typo3/cms": { "extension-key": "....", "Package": { "title": "...." } } } -
Helmut Hummel commented on patch set 4 10/20/21, 10:39
PackageManager.php:898ReplyCorrect -
Helmut Hummel uploaded patch set 5 10/20/21, 11:30
-
Helmut Hummel commented on patch set 5 10/20/21, 11:31
PackageManager.php:898ReplyResolved by not introducing a new public config option for the title for now -
core-ci voted on patch set 5 V +1 10/20/21, 11:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18382
-
Benni Mack voted on patch set 5 CR +1 10/20/21, 19:07
-
Simon Gilli commented on patch set 5 CR -1 10/20/21, 19:39
PackageArtifactBuilder.php:114I'm not happy with such includes. Well, it's done in other places too, I know, but how about using a closure to have a scope isolated include here? See also https://github.com/symfony/symfony/blob/ec34dd592e0411945bdf8e3c0a6a6378cd98fa6f/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php#L58-L61 -
Simon Gilli commented on patch set 5 10/20/21, 19:44
PackageArtifactBuilder.php:114ReplyMaybe we sould provide a generic file loader in the core which can be used also in other places... -
Benni Mack commented on patch set 5 10/21/21, 07:19
PackageArtifactBuilder.php:114ReplyI think we should keep this change (especially in the ArtifactBuilder) as lowlevel as possible. By the way, this change allows us to get rid of most of the other "include" places in Core, so I'm for keeping it like this. -
Simon Gilli commented on patch set 5 10/21/21, 10:03
PackageArtifactBuilder.php:114ReplyYes true, the ArtifactBuilder is some kind of special and should not relay on too much core code. This isn't a blocker for this patch sure, just like to have other opinions. If Helmut also agrees I will continue with testing this patch... -
Simon Gilli voted on patch set 5 V +1 10/21/21, 10:23
-
Helmut Hummel commented on patch set 5 10/21/21, 10:48
PackageArtifactBuilder.php:114ReplyThe code here is, like you said an exact copy of other places that reads the emconf files. I agree this code is ugly. But: * This code has lead to 0 issues in a decade for this use case * The goal is to remove the need for these files (and therefore this code can just be deleted entirely in a pretty near future) Adding a scoped include makes only sense to avoid potential issues in the future, which didn't exist in the past, but would still keep the general ugliness of this "API". So I came to the conclusion to keep this as bare bone as we can have it and remove the whole concept as quickly as possible. -
Helmut Hummel commented on patch set 5 10/21/21, 10:49
PackageArtifactBuilder.php:114ReplyI mark this as resolved -
Simon Gilli voted on patch set 5 CR +1 10/21/21, 10:50
-
Benni Mack voted on patch set 5 V +1 10/21/21, 12:12
-
Helmut Hummel voted on patch set 5 V +2 CR +2 10/21/21, 12:26
-
Helmut Hummel merged patch set 6 10/21/21, 12:27
PackageArtifactBuilder.php:104