71890[TASK] Do not cache phpunit results
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
Review log 911
-
Christian Kuhn uploaded patch set 1 10/19/21, 15:59
-
Mathias Brodala commented on patch set 1 10/19/21, 16:02
-
Christian Kuhn updated the commit message in patch set 2 10/19/21, 16:02
-
Christian Kuhn commented on patch set 2 10/19/21, 16:05
.gitignore:37Replyphpunit writes this file parallel to the .xml file by default. Since probably 'nobody' uses the mentioned commands of the commit message anyway (there is simply not much benefit), I decided to drop the .gitignore entry, too. *if* anyone pushed a patch including that file, we should see that in the review. -
Christian Kuhn commented on patch set 2 10/19/21, 16:06
.gitignore:37Replyah, and running phpunit without option -c to point to the .xml file does not make sense for monorepo, either. and we have runTests.sh to take care of this. So imho fine to not have .gitignore's for this file. -
core-ci voted on patch set 1 V +1 10/19/21, 16:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18329
-
Stefan Bürk commented on patch set 2 V +1 CR +1 10/19/21, 16:15
.gitignore:37ReplyAck. -
core-ci voted on patch set 2 V +1 10/19/21, 16:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18330
-
Wouter Wolters voted on patch set 2 V +1 CR +1 10/19/21, 16:27
-
Christian Kuhn voted on patch set 2 V +2 CR +2 10/19/21, 16:28
-
Christian Kuhn merged patch set 3 10/19/21, 16:28
.gitignore:37