71891[BUGFIX] Avoid listing root composer package in extension manager
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 67
-
Oliver Hader uploaded patch set 1 10/19/21, 16:32
-
Oliver Hader commented on patch set 1 10/19/21, 16:43
I'm not sure whether listing the root composer package is the expected behavior. For comparison, other composer packages used in the TYPO3 realm, like `typo3/phar-stream-wrapper`, `typo3/html-sanitizer` or `typo3fluid/fluid` are not listed. -
core-ci voted on patch set 1 V -1 10/19/21, 16:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18331
-
Helmut Hummel commented on patch set 1 CR -2 10/19/21, 17:11
let's discuss first what exactly the issue here is. showing something in EM and therefore excluding it from the API is something completely different. -
Oliver Hader commented on patch set 1 CR -1 10/19/21, 17:14
`PackageArtifactBuilder` seems to be too broad for this specific problem. Sounds more like `PackageManager::$packages` & companions... -
Helmut Hummel commented on patch set 1 10/20/21, 08:15
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/71897 for a suggestion how to solve this -
Oliver Hader abandoned the change 10/20/21, 10:04
Better solution → https://review.typo3.org/c/Packages/TYPO3.CMS/+/71897