71892[BUGFIX] Avoid deprecated methods in DebuggerUtility
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1520
-
Stefan Bürk uploaded patch set 1 10/19/21, 16:40
-
Stefan Bürk updated the commit message in patch set 2 10/19/21, 16:46
-
core-ci voted on patch set 1 V +1 10/19/21, 16:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18332
-
core-ci voted on patch set 2 V +1 10/19/21, 17:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18333
-
Christian Kuhn commented on patch set 2 10/19/21, 17:16
-
Christian Kuhn uploaded patch set 3 10/19/21, 17:16
-
Christian Kuhn commented on patch set 3 10/19/21, 17:17
this should have some dedicated php >= 8.0 tests. -
Christian Kuhn voted on patch set 3 CR -1 10/19/21, 17:17
-
Christian Kuhn commented on patch set 3 10/19/21, 17:27
UnitTests.xml:48ah, i shouldn't have pushed this. -
Christian Kuhn uploaded patch set 4 10/19/21, 17:27
-
core-ci voted on patch set 3 V -1 10/19/21, 17:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18335
-
core-ci voted on patch set 4 V +1 10/19/21, 17:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18336
-
Christian Kuhn commented on patch set 4 CR -1 10/19/21, 20:08
we'll try to come up with some tests. -
Stefan Bürk uploaded patch set 5 10/19/21, 20:32
-
Stefan Bürk commented on patch set 5 10/19/21, 20:38
Reply
I added some tests in general. Tests for "union type" (8.0) or "union intersect types" (8.1) are not possible, as these would be compile errors instantly. As the goal was to avoid the depcrecation method, and the reflection do not take other types than "array" or a "class" into account, I would ommit this for now. DebuggerUtillity should be revisted / overworked if php 8.1 is min req, and as such these types can be supported.DebuggerUtility.php:626ReplyRemoved that methods, and as such - no. -
core-ci voted on patch set 5 V +1 10/19/21, 20:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18344
-
Christian Kuhn voted on patch set 5 V +1 CR +1 10/19/21, 20:48
-
Wouter Wolters voted on patch set 5 V +1 CR +1 10/19/21, 21:05
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/19/21, 21:39
-
Christian Kuhn merged patch set 6 10/19/21, 21:40
DebuggerUtility.php:626