71893[TASK] Disable downloading extension archive in composer mode
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Wouter Wolters +1
- Markus Klein +1
- Simon Gilli +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oliver Hader +2
- Markus Klein +1
- Simon Gilli +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 910
-
Oliver Hader uploaded patch set 1 10/19/21, 16:58
-
Wouter Wolters voted on patch set 1 CR +1 10/19/21, 17:00
-
Simon Schaufelberger commented on patch set 1 10/19/21, 17:02
why is it useful to have it enabled in standard mode and disabled in composer mode? -
core-ci voted on patch set 1 V +1 10/19/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18334
-
Christian Kuhn commented on patch set 1 CR +1 10/19/21, 17:26
Reply
We don't know what people did with extensions in non-composer mode and it might be useful for authors to 'just download source'. In composer mode, ext source is packagist.org / packagist.com, or a local repository. It does not make much sense to d/l extension source here. -
Markus Klein voted on patch set 1 V +1 CR +1 10/19/21, 17:28
-
Simon Gilli voted on patch set 1 V +1 CR +1 10/19/21, 17:41
-
Christian Kuhn voted on patch set 1 V +1 10/19/21, 18:24
-
Oliver Hader voted on patch set 1 V +2 CR +2 10/19/21, 18:25
-
Oliver Hader merged patch set 2 10/19/21, 18:25