Review main Abandoned

71894[BUGFIX] Ensure DI works for ConfirmationFinisher in ext:form

Torben Hansen CR 0 V 0 Easy +3 −0 updated 11/05/21, 07:10

Commit message

In ext:form, the ConfirmationFinisher is instantiated using
GeneralUtility::makeInstance. Since the class is not marked
as public, inject-Methods are not called by the DI.

This patch ensures that the class is marked as public in
Services.yaml, so required dependencies are injected.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Torben Hansen uploaded patch set 1 10/19/21, 18:24

  2. core-ci voted on patch set 1 V +1 10/19/21, 18:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18337

  3. Christian Kuhn commented on patch set 1 CR -1 10/19/21, 20:10

    Thx Torben. Please give me a chance to review, will -1 for i small while. Need to have some fine tuning on some other extbase related classes towards DI, and would like to see the context.
  4. Torben Hansen abandoned the change 11/05/21, 07:10