Review main Merged

71895[BUGFIX] Split ContainerTest fixtures per class

Christian Kuhn CR +2 V +2 Expert +1028 −482 updated 10/19/21, 20:02

Commit message

Having more than one class per file is discouraged
and leads to issues with class-alias-loader
if non-namespaced classes are handled.

The test classes are target of test subject
extbase Container, which is deprecated. We don't
care that too much and simply split file
Testclasses.php into single files to get rid of
the issue.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 35

Show 15 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 10/19/21, 18:55

  2. Christian Kuhn updated the commit message in patch set 2 10/19/21, 19:02

  3. core-ci voted on patch set 1 V +1 10/19/21, 19:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18340

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 10/19/21, 19:11

  5. core-ci voted on patch set 2 V +1 10/19/21, 19:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18342

  6. Simon Gilli voted on patch set 2 V +1 CR +1 10/19/21, 19:58

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 10/19/21, 20:00

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/19/21, 20:02

  9. Christian Kuhn merged patch set 3 10/19/21, 20:02