Review main Merged

71896[BUGFIX] Avoid Serializable interface deprecation in extbase tests

Christian Kuhn CR +2 V +2 Easy +12 −2 updated 10/19/21, 21:38

Commit message

\Serializable interface has been deprecated with
PHP 7.4 and the introduction of __serialize() and
__unserialize().

There are two strategies to avoid deprecations: Either
skip implementation of \Serializable and only
implement the magics, or implement both to suppress
a E_DEPRECATED and fully stay b/w compatible.

Since this part of ContainerTest is about Serializable
interface directly, this patch picks the b/w compat way
and just additionally implements the two magic methods
in fixture class t3lib_object_tests_serializable.

Test subject class extbase container will vanish in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 10/19/21, 20:41

  2. Christian Kuhn updated the commit message in patch set 2 10/19/21, 20:42

  3. Christian Kuhn updated the commit message in patch set 3 10/19/21, 20:45

  4. core-ci voted on patch set 1 V +1 10/19/21, 20:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18345

  5. Stefan Bürk voted on patch set 3 V +1 CR +1 10/19/21, 20:55

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 10/19/21, 20:56

  7. core-ci voted on patch set 2 V +1 10/19/21, 20:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18346

  8. core-ci voted on patch set 3 V +1 10/19/21, 21:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18347

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 10/19/21, 21:38

  10. Christian Kuhn merged patch set 4 10/19/21, 21:38