Review main Merged

71899[BUGFIX] Deprecation free Serializable usage in backend Tree

Christian Kuhn CR +2 V +2 Normal +53 −8 updated 10/23/21, 14:56

Commit message

Classes TreeNode and TreeNodeCollection implement
deprecated \Serializable either directly, or indirectly
via \ArrayObject.

Adding the magic methods suppresses PHP 7.4
E_DEPRECATED messages and retains compatibilty,
slated for removal in v12.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1117

  1. Christian Kuhn uploaded patch set 1 10/19/21, 21:34

  2. Christian Kuhn updated the commit message in patch set 2 10/19/21, 21:35

  3. Stefan Bürk voted on patch set 2 V +1 CR +1 10/19/21, 22:13

  4. Christian Kuhn voted on patch set 2 CR -1 10/19/21, 22:17

  5. Christian Kuhn uploaded patch set 3 10/19/21, 23:06

  6. core-ci voted on patch set 1 V -1 10/19/21, 23:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18351

  7. core-ci voted on patch set 2 V -1 10/19/21, 23:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18352

  8. core-ci voted on patch set 3 V -1 10/19/21, 23:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18360

  9. Christian Kuhn uploaded patch set 4 10/20/21, 00:17

  10. Christian Kuhn uploaded patch set 5 10/20/21, 00:21

  11. core-ci voted on patch set 4 V +1 10/20/21, 00:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18363

  12. core-ci voted on patch set 5 V +1 10/20/21, 00:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18364

  13. Stefan Bürk uploaded patch set 6 10/23/21, 08:48

  14. core-ci voted on patch set 6 V +1 10/23/21, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18434

  15. Stefan Bürk voted on patch set 6 V +1 CR +1 10/23/21, 09:49

  16. Benni Mack voted on patch set 6 V +2 CR +2 10/23/21, 14:56

  17. Benni Mack merged patch set 7 10/23/21, 14:56