Review main Merged

71900[TASK] Deprecation free Serializable usage in ObjectStorage

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 10/19/21, 23:50

Commit message

extbase ObjectStorage always had a serialize() and
unserialize(), even though they always just threw
exceptions. This is probably for historical reasons
where ObjectStorage implemented further SPL classes
and had to satisfy interfaces.

To still prevent instances of ObjectStorage can be
serialized or unserialized, we rename the two
methods to the magic method names and still throw
the exceptions. This avoids shenanigans in classes
that extend ObjectStorage.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1521

  1. Christian Kuhn uploaded patch set 1 10/19/21, 22:02

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/19/21, 22:06

  3. core-ci voted on patch set 1 V -1 10/19/21, 22:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18353

  4. Christian Kuhn uploaded patch set 2 10/19/21, 22:24

  5. Simon Gilli commented on patch set 2 CR +1 10/19/21, 22:37

    Looks good now
  6. core-ci voted on patch set 2 V +1 10/19/21, 22:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18355

  7. Christian Kuhn commented on patch set 2 CR -1 10/19/21, 22:44

    will update commit message.
  8. Christian Kuhn updated the commit message in patch set 3 10/19/21, 22:47

  9. Christian Kuhn updated the commit message in patch set 4 10/19/21, 22:47

  10. Christian Kuhn updated the commit message in patch set 5 10/19/21, 22:47

  11. Christian Kuhn voted on patch set 5 CR -1 10/19/21, 22:52

  12. Christian Kuhn uploaded patch set 6 10/19/21, 22:56

  13. Christian Kuhn commented on patch set 6 10/19/21, 22:58

    third solution on this ... this one should be fine i think.
  14. core-ci voted on patch set 3 V +1 10/19/21, 23:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18356

  15. core-ci voted on patch set 4 V +1 10/19/21, 23:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18357

  16. core-ci voted on patch set 5 V +1 10/19/21, 23:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18358

  17. core-ci voted on patch set 6 V +1 10/19/21, 23:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18359

  18. Simon Gilli voted on patch set 6 V +1 CR +1 10/19/21, 23:17

  19. Stefan Bürk voted on patch set 6 V +1 CR +1 10/19/21, 23:50

  20. Christian Kuhn voted on patch set 6 V +2 CR +2 10/19/21, 23:50

  21. Christian Kuhn merged patch set 7 10/19/21, 23:50