71901[BUGFIX] Add PHP 8.1 compatibility in AbstractRecordCollection
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- crell +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Stefan Bürk uploaded patch set 1 10/19/21, 22:05
-
core-ci voted on patch set 1 V +1 10/19/21, 22:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18354
-
Stefan Bürk voted on patch set 1 CR -1 10/19/21, 22:25
-
Stefan Bürk wrote 10/19/21, 22:34
Removed Code-Review-1 by Stefan Bürk <stefan@buerk.tech> -
Stefan Bürk uploaded patch set 2 10/20/21, 00:08
-
Stefan Bürk uploaded patch set 3 10/20/21, 00:11
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/20/21, 00:12
-
core-ci voted on patch set 3 V +1 10/20/21, 00:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18362
-
core-ci voted on patch set 2 V -1 10/20/21, 00:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18361
-
crell commented on patch set 3 10/21/21, 15:09
AbstractRecordCollection.php:220An int return type is compatible with 7.4, so that can be done now. -
Stefan Bürk commented on patch set 3 10/21/21, 15:14
AbstractRecordCollection.php:220Replyint would be 7.4 compatible, yes. But adding here ':int' return type would change the signature, and classes extend this may break if they have no/not that return type. So this would be breaking, which we cannot do in v11. See: https://3v4l.org/frkqe -
crell commented on patch set 3 10/21/21, 15:16
AbstractRecordCollection.php:220ReplyUgh, stupid extending classes... Note that in the comment, then, as the reason why we can't do it now. (Because the PHP version isn't the blocker, LTS status is.) -
Stefan Bürk uploaded patch set 4 10/21/21, 15:36
-
Stefan Bürk commented on patch set 4 10/21/21, 15:37
AbstractRecordCollection.php:220ReplyDone -
core-ci voted on patch set 4 V +1 10/21/21, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18406
-
crell voted on patch set 4 CR +1 10/21/21, 19:22
-
Jochen Roth voted on patch set 4 V +1 CR +1 10/22/21, 08:22
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/23/21, 18:20
-
Christian Kuhn merged patch set 5 10/23/21, 18:21