Review main Merged

71902[BUGFIX] Remove mssql quotes in QueryHelper::parseJoin()

Stefan Bürk CR +2 V +2 Normal +111 −9 updated 10/20/21, 17:39

Commit message

Recently adding quote syntax to typoscript
definitions has been added through #94715,
which fails in nightly on mssql.

Quotes has been removed from the join part of
a query build in TypoScript content objects,
to let dbal handle the dbms quoting.
QueryHelper::parseJoin() has done this only
for '"' and '`', leaving out the quoting for
mssql, which uses brackets, thus not removing them.

This patch removes mssql quoting style
characters from the join part to mitigate
this issue, which also make nightly green.
Further there are tests added to cover
these cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1216

  1. Stefan Bürk uploaded patch set 1 10/20/21, 09:52

  2. Stefan Bürk commented on patch set 1 CR -1 10/20/21, 09:53

    Waiting for pre-merge, and if green torture with nightly.
  3. core-ci voted on patch set 1 V +1 10/20/21, 10:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18378

  4. Stefan Bürk commented on patch set 1 10/20/21, 10:19

  5. core-ci commented on patch set 1 10/20/21, 11:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18379

  6. Stefan Bürk uploaded patch set 2 10/20/21, 11:11

  7. core-ci voted on patch set 2 V +1 10/20/21, 11:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18380

  8. Jochen Roth commented on patch set 2 10/20/21, 11:30

    QueryHelper.php:227

    Seems like this is unused.
  9. Christian Kuhn uploaded patch set 3 10/20/21, 12:45

  10. Christian Kuhn commented on patch set 3 10/20/21, 12:46

    QueryHelper.php:227 Reply

    Done
  11. core-ci voted on patch set 3 V +1 10/20/21, 12:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18386

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 10/20/21, 14:09

  13. Jochen Roth voted on patch set 3 V +1 CR +1 10/20/21, 14:11

  14. Benni Mack voted on patch set 3 V +1 CR +1 10/20/21, 15:18

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 10/20/21, 17:38

  16. Christian Kuhn merged patch set 4 10/20/21, 17:39