Review main Merged

71903[BUGFIX] Avoid using HTML sanitizer in reports module

Oliver Hader CR +2 V +2 Easy +1 −1 updated 10/21/21, 11:45

Commit message

Reports generated by custom data providers might contain
specific HTML markup (including JavaScript, SVG and styles).
The changes of issue #95179 introduced XSS-safe HTML sanitization,
which however breaks existing functionality for mentioned markups.
Thus, HTML sanitization is dropped again in this particular scenario.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 10/20/21, 11:21

  2. core-ci voted on patch set 1 V +1 10/20/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18381

  3. Georg Ringer voted on patch set 1 V +1 CR +1 10/20/21, 12:17

  4. Benni Mack voted on patch set 1 V +1 CR +1 10/21/21, 09:00

  5. Oliver Hader voted on patch set 1 V +2 CR +2 10/21/21, 11:45

  6. Oliver Hader merged patch set 2 10/21/21, 11:45