Review 10.4 Merged

71914[BUGFIX] Make file paths absolute in GIFBUILDER

Benni Mack CR +2 V +2 Normal +51 −6 updated 11/11/21, 13:13

Commit message

In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inconsistency, absolute
file paths are used from now on.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Benni Mack commented on patch set 1 10/21/21, 15:13

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 10/21/21, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18405

  3. Stefan Bürk commented on patch set 1 CR -1 10/21/21, 15:49

    on it
  4. Stefan Bürk uploaded patch set 2 10/21/21, 15:54

  5. Stefan Bürk uploaded patch set 3 10/21/21, 15:55

  6. core-ci voted on patch set 2 V -1 10/21/21, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18407

  7. core-ci voted on patch set 3 V +1 10/21/21, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18408

  8. Simon Schaufelberger voted on patch set 3 V +1 CR +1 10/21/21, 16:03

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 10/21/21, 16:04

  10. Benni Mack voted on patch set 3 V +2 CR +2 10/22/21, 06:39

  11. Benni Mack merged patch set 4 10/22/21, 06:39

  12. Benni Mack wrote 11/11/21, 13:13

    Created a revert of this change as I0065bb2db480f29fea12890cdfb3d34b57c94eef