Review 10.4 Merged

71924[BUGFIX] Fix EditableRestriction for linkvalidator

Anja Leichsenring CR +2 V +2 Normal +40 −14 updated 11/05/21, 10:20

Commit message

EditableRestriction in linkvalidator checks which fields are editable
Doing so, it also considers the allow / deny types (explicit_allowdeny
in be_groups). However, there were previously 2 problems which resulted
in broken links not displayed for some tables (e.g. in
tx_news_domain_model_news):

1. If the type was '0', no value was written to tx_linkvalidator_link.
   element_type.
2. If ctrl => type was set in TCA, but authMode is not or
   authMode_enforce == 'strict', the check should not be performed.

Both problems are now fixed. The fix for problem 1 requires a rechecking
of links so that the element_type field will be filled.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 11/05/21, 10:04

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/05/21, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18935

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 11/05/21, 10:20

  4. Anja Leichsenring merged patch set 2 11/05/21, 10:20