Review 10.4 Abandoned

71932[BUGFIX] Restore inconsistent language highlighting

Georg Ringer CR 0 V 0 Easy +12 −0 updated 11/03/21, 12:26

Commit message

The page module displays a flash message for page
translations with inconsistent ("mixed mode") content
elements. The last sentence of the flash message reads:
"We highlighted the problematic records for you". This
however was no longer the case in the fluid based page
module.

Therefore, this patch restores highlighting of such records.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 10/21/21, 12:06

  2. Georg Ringer commented on patch set 1 10/21/21, 12:07

    This change is ready for review.
  3. Markus Klein voted on patch set 1 CR +1 10/21/21, 12:13

  4. core-ci voted on patch set 1 V +1 10/21/21, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18400

  5. anonymized-52878 voted on patch set 1 CR +1 10/21/21, 12:37

  6. anonymized-52878 commented on patch set 1 V +1 10/27/21, 08:25

    I testet the patch - it works like expected. Note: Tthe behaviour changed from "danger" (red highlight in V9) to "warning" (orange highlight). I personal like the idea and would consider this as improvement, because its no error but just a hint to editors to pay attantion. Depending on the fallbacktype in FE the highlighted contents could be no problem at all. Sitenote: Best would be to make the waring and highlighting dependent on the fallbacktype set in current site. fallbacktype "strict" and "fallback" -> show warning/highlight (maybe even "danger" again); "free" -> no waringn/highlight.
  7. Guido Schmechel voted on patch set 1 CR +1 10/30/21, 09:18

  8. Andreas Kienast voted on patch set 1 CR +1 11/01/21, 10:47

  9. Oli Bartsch uploaded patch set 2 11/02/21, 09:22

  10. Oli Bartsch commented on patch set 2 V +1 CR +1 11/02/21, 09:24

    To be consistent with the PageLayoutView variant in v10, the mixed mode highlighting must be "danger", since "warning" is used for elements in unused columns. In v11 this had been reworked.
  11. core-ci voted on patch set 2 V +1 11/02/21, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18745

  12. Anja Leichsenring abandoned the change 11/03/21, 12:26

    in order to align the change-Ids and maintain the connection of the patches, I repushed this to https://review.typo3.org/c/Packages/TYPO3.CMS/+/72031