Review main Merged

71934[BUGFIX] Avoid error when loading title of TCA table in New Record Controller

Benni Mack CR +2 V +2 Easy +12 −15 updated 10/25/21, 14:54

Commit message

This change uses the PackageManager API to fetch the
extension key title, and also solves a small issue when
the TCA title is not prefixed with "LLL:".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Benni Mack uploaded patch set 1 10/21/21, 14:53

  2. core-ci voted on patch set 1 V +1 10/21/21, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18402

  3. Simon Schaufelberger voted on patch set 1 CR +1 10/23/21, 12:39

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/23/21, 13:03

  5. Nikita Hovratov commented on patch set 1 CR -1 10/23/21, 16:28

    NewRecordController.php:502

    I think this should be locallang_db.xlf. See here: https://docs.typo3.org/m/typo3/book-extbasefluid/master/en-us/4-FirstExtension/4-make-products-persistent.html#language-file Funilly, this is the only place I found a documentation for it.
  6. Nikita Hovratov updated the commit message in patch set 2 10/23/21, 16:29

  7. core-ci voted on patch set 2 V +1 10/23/21, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18448

  8. Stefan Bürk commented on patch set 2 10/24/21, 12:42

    NewRecordController.php:502 Reply

    Reading that documentation you are right.
  9. Benni Mack commented on patch set 3 10/25/21, 12:19

    Published edit on patch set 2.
  10. core-ci voted on patch set 3 V +1 10/25/21, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18527

  11. Nikita Hovratov commented on patch set 3 V +1 CR +1 10/25/21, 13:12

    NewRecordController.php:502 Reply

    Done
  12. Stefan Bürk voted on patch set 3 V +1 CR +1 10/25/21, 13:18

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 10/25/21, 14:54

  14. Christian Kuhn merged patch set 4 10/25/21, 14:54