Review main Merged

71936[BUGFIX] Use correct return type annotations in validation results

Robert Kärner CR +2 V +2 Easy +3 −3 updated 10/24/21, 15:40

Commit message

Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are accessed
in custom extensions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Robert Kärner uploaded patch set 1 10/22/21, 08:48

  2. core-ci voted on patch set 1 V +1 10/22/21, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18419

  3. Oliver Klee voted on patch set 1 CR +1 10/22/21, 09:59

  4. Guido Schmechel voted on patch set 1 CR +1 10/23/21, 14:40

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 10/24/21, 12:45

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/24/21, 15:40

  7. Christian Kuhn merged patch set 2 10/24/21, 15:40