71938[BUGFIX] Fix translation handling in vendor packages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Gilli +1
- Helmut Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Gilli +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php10+30 −1
- typo3/sysext/core/Classes/Localization/LanguageStore.php6+34 −1
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+11 −4
- typo3/sysext/core/Classes/Package/PackageManager.php10+20 −3
- typo3/sysext/core/Classes/ServiceProvider.php+2 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+37 −0
- typo3/sysext/extbase/Tests/Unit/Utility/LocalizationUtilityTest.php+7 −3
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+4 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −1
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+9 −4
Review log 88143
Show 70118 earlier messages
-
Simon Gilli uploaded patch set 1 10/22/21, 09:33
-
core-ci voted on patch set 1 V -1 10/22/21, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18422
-
Simon Gilli commented on patch set 1 10/22/21, 10:37
PackageManager.php:322message should be adapted here -
Simon Gilli uploaded patch set 2 10/23/21, 14:26
-
Simon Gilli commented on patch set 2 10/23/21, 14:27
PackageManager.php:322ReplyDone -
Simon Gilli commented on patch set 2 10/23/21, 14:30
AbstractXmlParser.php:44ReplyDoneXliffParserTest.php:119should be moved to a functional test imhoXliffParserTest.php:157should be moved to a functional test imho -
core-ci voted on patch set 2 V -1 10/23/21, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18442
-
Simon Gilli uploaded patch set 3 10/23/21, 19:33
-
core-ci voted on patch set 3 V -1 10/23/21, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18457
-
Simon Gilli commented on patch set 3 10/23/21, 19:40
AbstractXmlParser.php:36we should get rid of the property here and just pass the value as paramter where neededAbstractXmlParser.php:41we should get rid of the property here and just pass the value as paramter where neededXliffParserTest.php:119ReplyDoneXliffParserTest.php:157ReplyDone -
Simon Gilli uploaded patch set 4 10/23/21, 19:40
-
core-ci voted on patch set 4 V -1 10/23/21, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18459
-
Simon Gilli uploaded patch set 5 10/23/21, 19:44
-
core-ci voted on patch set 5 V -1 10/23/21, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18460
-
Simon Gilli rebased onto patch set 6 10/23/21, 20:19
-
core-ci voted on patch set 6 V -1 10/23/21, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18464
-
Simon Gilli uploaded patch set 7 10/23/21, 22:18
-
core-ci voted on patch set 7 V +1 10/23/21, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18475
-
Simon Gilli uploaded patch set 8 10/23/21, 22:53
-
Simon Gilli commented on patch set 8 10/23/21, 22:54
AbstractXmlParser.php:36ReplyDoneAbstractXmlParser.php:41ReplyDone -
Simon Gilli uploaded patch set 9 10/23/21, 23:00
-
core-ci voted on patch set 8 V +1 10/23/21, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18477
-
Simon Gilli commented on patch set 9 10/23/21, 23:08
AbstractXmlParser.php:31is imho superfluous but added for the moment for the unit tests. should be removed, the public service declaration should be sufficient. -
core-ci voted on patch set 9 V +1 10/23/21, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18479
-
Simon Gilli uploaded patch set 10 10/24/21, 13:42
-
core-ci voted on patch set 10 V -1 10/24/21, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18497
-
Simon Gilli uploaded patch set 11 10/24/21, 13:49
-
core-ci voted on patch set 11 V -1 10/24/21, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18498
-
Simon Gilli uploaded patch set 12 10/24/21, 13:53
-
Simon Gilli uploaded patch set 13 10/24/21, 13:56
-
core-ci voted on patch set 12 V -1 10/24/21, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18499
-
core-ci voted on patch set 13 V +1 10/24/21, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18500
-
Simon Gilli uploaded patch set 14 10/24/21, 23:22
-
Simon Gilli commented on patch set 14 10/24/21, 23:24
AbstractXmlParser.php:31ReplyDone -
core-ci voted on patch set 14 V -1 10/24/21, 23:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18510
-
Simon Gilli uploaded patch set 15 10/24/21, 23:35
-
core-ci voted on patch set 15 V -1 10/24/21, 23:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18511
-
Simon Gilli uploaded patch set 16 10/24/21, 23:41
-
core-ci voted on patch set 16 V -1 10/24/21, 23:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18512
-
Simon Gilli uploaded patch set 17 10/25/21, 00:00
-
core-ci voted on patch set 17 V +1 10/25/21, 00:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18513
-
Simon Gilli uploaded patch set 18 10/25/21, 09:47
-
Simon Gilli uploaded patch set 19 10/25/21, 09:52
-
core-ci voted on patch set 18 V +1 10/25/21, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18517
-
Simon Gilli uploaded patch set 20 10/25/21, 10:06
-
core-ci voted on patch set 19 V +1 10/25/21, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18519
-
core-ci voted on patch set 20 V +1 10/25/21, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18521
-
Simon Gilli uploaded patch set 21 10/25/21, 10:32
-
core-ci voted on patch set 21 V +1 10/25/21, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18525
-
Simon Gilli uploaded patch set 22 10/25/21, 11:27
-
core-ci voted on patch set 22 V +1 10/25/21, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18526
-
Simon Gilli uploaded patch set 23 10/25/21, 12:34
-
core-ci voted on patch set 23 V -1 10/25/21, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18529
-
Simon Gilli uploaded patch set 24 10/25/21, 13:11
-
core-ci voted on patch set 24 V +1 10/25/21, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18531
-
Simon Gilli uploaded patch set 25 10/25/21, 14:15
-
Simon Gilli uploaded patch set 26 10/25/21, 14:16
-
core-ci voted on patch set 25 V +1 10/25/21, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18536
-
Simon Gilli uploaded patch set 27 10/25/21, 14:30
-
core-ci voted on patch set 27 V +1 10/25/21, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18538
-
core-ci voted on patch set 26 V +1 10/25/21, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18537
-
Simon Gilli uploaded patch set 28 10/27/21, 09:18
-
Simon Gilli uploaded patch set 29 10/27/21, 09:20
-
core-ci voted on patch set 28 V +1 10/27/21, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18612
-
core-ci voted on patch set 29 V +1 10/27/21, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18613
-
Simon Gilli uploaded patch set 30 10/27/21, 21:40
-
Simon Gilli uploaded patch set 31 10/27/21, 21:53
-
Simon Gilli commented on patch set 31 10/27/21, 21:57
AbstractXmlParser.php:143Wondering if we could use basename() and dirname() here instead. -
core-ci voted on patch set 30 V +1 10/27/21, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18635
-
core-ci voted on patch set 31 V -1 10/27/21, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18636
-
Simon Gilli uploaded patch set 32 10/27/21, 22:34
-
core-ci voted on patch set 32 V +1 10/27/21, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18637
-
Simon Gilli uploaded patch set 33 10/30/21, 22:34
-
core-ci voted on patch set 33 V -1 10/30/21, 22:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18691
-
Simon Gilli uploaded patch set 34 10/31/21, 00:10
-
core-ci voted on patch set 34 V +1 10/31/21, 00:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18693
-
Simon Gilli uploaded patch set 35 10/31/21, 16:09
-
Simon Gilli commented on patch set 35 10/31/21, 16:10
AbstractXmlParser.php:143ReplyDone -
core-ci voted on patch set 35 V -1 10/31/21, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18699
-
Simon Gilli uploaded patch set 36 11/01/21, 12:37
-
Simon Gilli updated the commit message in patch set 37 11/01/21, 12:48
-
Simon Gilli updated the commit message in patch set 38 11/01/21, 12:50
-
core-ci voted on patch set 36 V +1 11/01/21, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18722
-
Simon Gilli commented on patch set 38 11/01/21, 12:56
This change is ready for review. -
core-ci voted on patch set 37 V +1 11/01/21, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18723
-
core-ci voted on patch set 38 V +1 11/01/21, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18724
-
Simon Gilli uploaded patch set 39 11/01/21, 16:42
-
Simon Gilli commented on patch set 39 CR -1 11/01/21, 16:55
Test for one new method in PackageManager is currently missing... -
core-ci voted on patch set 39 V -1 11/01/21, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18726
-
Simon Gilli uploaded patch set 40 11/01/21, 17:56
-
Simon Gilli commented on patch set 40 CR -1 11/01/21, 18:00
Test for one new method in PackageManager is currently missing... -
core-ci voted on patch set 40 V -1 11/01/21, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18727
-
Simon Gilli rebased onto patch set 41 11/01/21, 18:47
-
Simon Gilli marked it work in progress 11/01/21, 18:47
-
core-ci voted on patch set 41 V -1 11/01/21, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18729
-
Simon Gilli rebased onto patch set 42 11/01/21, 19:16
-
core-ci voted on patch set 42 V +1 11/01/21, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18731
-
Simon Gilli commented on patch set 42 V -1 11/02/21, 07:24
PackageManager.php:318regex is wrong -
Simon Gilli uploaded patch set 43 11/02/21, 12:17
-
Simon Gilli commented on patch set 43 11/02/21, 12:17
This change is ready for review.PackageManager.php:318ReplyDone -
Simon Gilli uploaded patch set 44 11/02/21, 12:20
-
Simon Gilli commented on patch set 44 CR -1 11/02/21, 12:23
PackageManager.php:276I would prefer to have a getter method instead. What do you think @Helmut? -
core-ci voted on patch set 43 V -1 11/02/21, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18748
-
Simon Gilli uploaded patch set 45 11/02/21, 12:41
-
Simon Gilli uploaded patch set 46 11/02/21, 12:43
-
core-ci voted on patch set 45 V -1 11/02/21, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18750
-
Simon Gilli uploaded patch set 47 11/02/21, 12:45
-
Helmut Hummel commented on patch set 47 11/02/21, 12:58
PackageManager.php:276ReplyAny improvement here should be along the lines of (re-)storing this regex from and into package cache. So I'd leave it like this for this bugfix. -
core-ci voted on patch set 46 V -1 11/02/21, 13:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18751
-
core-ci voted on patch set 47 V -1 11/02/21, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18752
-
core-ci voted on patch set 44 V -1 11/02/21, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18749
-
Simon Gilli uploaded patch set 48 11/02/21, 13:14
-
Helmut Hummel commented on patch set 48 11/02/21, 13:24
LanguageStore.php:163The file reference is always converted into an absolute file system path here.LanguageStore.php:222This is never an extension path at this point (see above) -
core-ci voted on patch set 48 V +1 11/02/21, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18759
-
Simon Gilli commented on patch set 48 11/02/21, 15:20
LanguageStore.php:163ReplyCorrect. That's why I always try to use the raw file ref from the LanguageService and that's also the reason for the change below.LanguageStore.php:222Reply$fileReference can be the raw data from the LanguageService, so yes this can ofc be an extension path. btw this change ensures the $fileReference never gets converted to an absolute path for the parser. The whole code is a mess and very hard to read and understand, after two weeks of working with this code I slowly get an idea about the details now... So like said before via PM we need to write this whole stuff from scratch as next step, it really does not make any sense to invest more time here. -
Helmut Hummel uploaded patch set 49 11/03/21, 16:52
-
Simon Gilli commented on patch set 49 11/03/21, 17:13
LanguageStore.php:62I would move this before the init call. -
Helmut Hummel commented on patch set 49 11/03/21, 17:16
LanguageStore.php:62ReplyAck
-
core-ci voted on patch set 49 V -1 11/03/21, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18801
-
Helmut Hummel uploaded patch set 50 11/03/21, 18:23
-
core-ci voted on patch set 50 V -1 11/03/21, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18809
-
Helmut Hummel uploaded patch set 51 11/03/21, 18:59
-
core-ci voted on patch set 51 V +1 11/03/21, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18813
-
Simon Gilli updated the commit message in patch set 52 11/03/21, 19:21
-
Simon Gilli commented on patch set 52 CR +1 11/03/21, 19:31
I guess that's it after almost 2 weeks of work on this patch. Testing now... -
core-ci voted on patch set 52 V +1 11/03/21, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18817
-
Simon Gilli voted on patch set 52 V +1 11/03/21, 19:44
-
Helmut Hummel uploaded patch set 53 11/08/21, 13:01
-
Helmut Hummel voted on patch set 53 V +1 CR +1 11/08/21, 13:02
-
Helmut Hummel uploaded patch set 54 11/08/21, 13:15
-
Helmut Hummel voted on patch set 54 V +1 CR +1 11/08/21, 13:17
-
core-ci voted on patch set 53 V -1 11/08/21, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19018
-
core-ci voted on patch set 54 V -1 11/08/21, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19019
-
Helmut Hummel uploaded patch set 55 11/08/21, 13:39
-
Helmut Hummel uploaded patch set 56 11/08/21, 13:41
-
core-ci voted on patch set 56 V +1 11/08/21, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19022
-
Simon Gilli commented on patch set 56 V +1 11/08/21, 14:29
PackageManager.php:315Can we use a stricter test than empty? Subject to change with higher PHPStan levels anyway so why not already doing it the right way. $matches[1] === '' should be fine. -
Helmut Hummel commented on patch set 56 11/08/21, 16:11
PackageManager.php:315ReplyI'd liked to be sure $match[1] is actually set, so the most explicit check would be: isset($match[1]) && $match[1] !== '' The only difference to empty($match[0]) would be that the empty would also be true for string '0', which I pretty much find acceptable here. So for my personal taste, empty() does its job and is more concise than isset($match[1]) && $match[1] !== '' But I honestly don't care too much -
Simon Gilli commented on patch set 56 CR +1 11/08/21, 16:23
PackageManager.php:315ReplyAck -
Helmut Hummel commented on patch set 56 11/08/21, 16:24
PackageManager.php:315ReplyLet's keep it like that for now -
Helmut Hummel voted on patch set 56 V +1 CR +1 11/08/21, 16:24
-
Benni Mack voted on patch set 56 V +2 CR +2 11/09/21, 07:20
-
Benni Mack merged patch set 57 11/09/21, 07:20
AbstractXmlParser.php:44