Review main Merged

71940[BUGFIX] Deprecation free ArrayObject usage in backend tree

Stefan Bürk CR +2 V +2 Easy +4 −0 updated 10/23/21, 18:36

Commit message

Classes TreeeNodeCollection and SortedTreeNodeCollection
extends ArrayObject and override some methods.

PHP 8.1 added concrete return types to internal objects
and methods which fails if extending classes do not have
compatible return types.

This patch adds the PHP 8.1 attribute #[\ReturnTypeWillChange]
to mitigate these fatal errors, as we cannot change the
return type yet without being breaking. Thus added @todo
to change the return types as breaking change in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Stefan Bürk uploaded patch set 1 10/23/21, 10:04

  2. core-ci voted on patch set 1 V +1 10/23/21, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18435

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/23/21, 18:27

  4. Christian Kuhn commented on patch set 1 V +2 CR +2 10/23/21, 18:29

    merging this as de-facto no-brainer since only comments are changed / added.
  5. Christian Kuhn merged patch set 2 10/23/21, 18:36