Review main Merged

71941[TASK] Make HtmlParser PHP8 compatible

Francois Suter CR +2 V +2 Easy +19 −16 updated 11/05/21, 12:34

Commit message

Class \TYPO3\CMS\Core\Html\HtmlParser generates a lot of undefined
key warnings when running with PHP 8. It needs to be cleaned up.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1518

  1. Francois Suter uploaded patch set 1 10/23/21, 10:39

  2. core-ci voted on patch set 1 V +1 10/23/21, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18436

  3. Sybille Peters voted on patch set 1 CR +1 10/23/21, 15:07

  4. Oliver Klee voted on patch set 1 CR +1 10/24/21, 08:14

  5. Stefan Bürk commented on patch set 1 CR -1 10/24/21, 11:42

    On it

    HtmlParser.php:549

    The added check only works for the first part, for the "or" part the array check is not done and could be also trigger array key warning.
  6. Stefan Bürk uploaded patch set 2 10/24/21, 11:42

  7. Stefan Bürk commented on patch set 2 CR +1 10/24/21, 11:44

    Code looks good, but do not know how to verify. Cases are not covered/triggerd by tests (so far), even with E_ALL activated.

    HtmlParser.php:549 Reply

    Done
  8. core-ci voted on patch set 2 V +1 10/24/21, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18495

  9. Oliver Klee wrote 10/24/21, 12:04

    Removed reviewer Oliver Klee.
  10. Andreas Kienast uploaded patch set 3 11/05/21, 10:50

  11. Andreas Kienast commented on patch set 3 11/05/21, 10:51

    Reply

    I managed to reproduce it with EXT:bootstrap_package installed and calling `/content-examples/text/rich-text` in the frontend.
  12. core-ci voted on patch set 3 V +1 11/05/21, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18938

  13. Jochen Roth voted on patch set 3 CR +1 11/05/21, 11:56

  14. Benni Mack voted on patch set 3 CR +1 11/05/21, 12:08

  15. Oliver Klee voted on patch set 3 CR +1 11/05/21, 12:22

  16. Benni Mack voted on patch set 3 V +1 11/05/21, 12:34

  17. Christian Kuhn voted on patch set 3 V +2 CR +2 11/05/21, 12:34

  18. Christian Kuhn merged patch set 4 11/05/21, 12:34