Review main Merged

71942[BUGFIX] Avoid incomplete setup in ExtensionStatusTest

Stefan Bürk CR +2 V +2 Easy +25 −5 updated 10/23/21, 18:38

Commit message

Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for  formatting messages.

In normal instances LanguageService would
return translated keys, or at least an empty
string.

Tests in ExtensionStatusTest has been mocking
the LanguageService, without correctly mocking
some methods, thus return null on translation.
This leads to 'sprintf()' calls with null
instead of empty strings, thus spawning these
depcrecation messages.

This patch add mocks for some methods of the
LanguageService mock to avoid these messages.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk uploaded patch set 1 10/23/21, 11:07

  2. Stefan Bürk commented on patch set 1 CR -1 10/23/21, 11:12

    Mabye that's just an issue of the tests. Will recheck.
  3. core-ci voted on patch set 1 V +1 10/23/21, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18437

  4. Stefan Bürk uploaded patch set 2 10/23/21, 12:05

  5. core-ci voted on patch set 2 V +1 10/23/21, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18438

  6. Christian Kuhn commented on patch set 2 V +2 CR +2 10/23/21, 18:38

    merging as near no-brainer in 'test only' code.
  7. Christian Kuhn merged patch set 3 10/23/21, 18:38