Review main Merged

71943[BUGFIX] Avoid incomplete setup in FileHandlingUtilityTest

Stefan Bürk CR +2 V +2 Easy +12 −2 updated 10/23/21, 18:50

Commit message

Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for  formatting messages.

In normal instances LanguageService would
return translated keys, or at least an empty
string.

Test in FileHandlingUtilityTest has been mocked
the LanguageServiceFactory to inject it into
a class, thus not providing a proper setup
LanguageService and return null instead of
an empty string as translation.

This patch change from mocked to prophezied
LanguageServiceFactory and LanguageServices
objects to avoid these deprecation messages
in PHP 8.1.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 10/23/21, 12:23

  2. core-ci voted on patch set 1 V +1 10/23/21, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18439

  3. Simon Gilli voted on patch set 1 V +1 CR +1 10/23/21, 18:41

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/21, 18:50

  5. Christian Kuhn merged patch set 2 10/23/21, 18:50