Review main Merged

71947[BUGFIX] Avoid deprecation message in MetaDataAspect

Stefan Bürk CR +2 V +2 Easy +4 −0 updated 10/23/21, 20:44

Commit message

MetaDataAspect implements multiple interfaces and has return type hints
that match the interfaces. Except for the offsetGet() and current()
methods, which are defined by the ArrayAccess and Iterator interfaces.

The 'mixed' return type cannot be used before PHP 8.0, so it cannot be
added yet.

This patch adds the attribute '#[\ReturnTypeWillChange]' to avoid the
fatal error for PHP 8.1 and @todo comments to change the correct return
types, as a breaking patch for TYPO3 v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 10/23/21, 19:58

  2. core-ci voted on patch set 1 V +1 10/23/21, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18461

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/23/21, 20:12

  4. Simon Gilli updated the commit message in patch set 2 10/23/21, 20:29

  5. Simon Gilli voted on patch set 2 V +1 CR +1 10/23/21, 20:30

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/23/21, 20:34

  7. core-ci voted on patch set 2 V +1 10/23/21, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18465

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/23/21, 20:44

  9. Christian Kuhn merged patch set 3 10/23/21, 20:44