Review main Merged

71950[BUGFIX] Avoid passing null as parameter to trim()

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/23/21, 21:29

Commit message

To make units test notice free in #85092 a wrong
fallback for array access has been used.

Fallback to null and passing to trim() through
null coalescing operator has been the wrong choice,
as it triggers a deprecation message in PHP 8.1.

This patch change the fallback to an empty string
instead to avoid this deprecation message.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 10/23/21, 20:55

  2. Christian Kuhn updated the commit message in patch set 2 10/23/21, 21:00

  3. Christian Kuhn voted on patch set 2 V +1 CR +1 10/23/21, 21:00

  4. Christian Kuhn updated the commit message in patch set 3 10/23/21, 21:01

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 10/23/21, 21:01

  6. core-ci voted on patch set 1 V +1 10/23/21, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18467

  7. core-ci voted on patch set 3 V +1 10/23/21, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18470

  8. core-ci voted on patch set 2 V +1 10/23/21, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18469

  9. Simon Gilli voted on patch set 3 V +1 CR +1 10/23/21, 21:23

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 10/23/21, 21:29

  11. Christian Kuhn merged patch set 4 10/23/21, 21:29