Review main Merged

71951[BUGFIX] Deprecation free ArrayObject in extbase Controller/Arguments

Stefan Bürk CR +2 V +2 Easy +15 −0 updated 10/23/21, 22:10

Commit message

ext:extbase Controller/Arguments extends ArrayObject
which implements several interfaces. Since PHP 8.1
added concrete return types this triggers deprecation
messages, and in cases of inheritance fatal.

This patch adds #[\ReturnTypeWillChange] to methods
as we cannot add concrete return types without beeing
breaking. Also add corresponding @todos to add them
as breaking patch in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/23/21, 21:48

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 10/23/21, 22:04

  3. core-ci voted on patch set 1 V +1 10/23/21, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18472

  4. Simon Gilli voted on patch set 1 V +1 CR +1 10/23/21, 22:06

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/21, 22:10

  6. Christian Kuhn merged patch set 2 10/23/21, 22:10