Review main Merged

71952[BUGFIX] Avoid invalid setup in Typo3StatusTest

Christian Kuhn CR +2 V +2 Easy +9 −3 updated 10/23/21, 22:41

Commit message

Let getLL() return string in tests to avoid a
"sprintf(): Passing null to parameter #1" from
Typo3Status test. Sanitize that sprintf().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Christian Kuhn uploaded patch set 1 10/23/21, 22:00

  2. Stefan Bürk commented on patch set 1 10/23/21, 22:09

    Typo3Status.php:66

    String cast should be superfluous here, but does not hurt anyway.
  3. Christian Kuhn commented on patch set 1 10/23/21, 22:14

    Typo3Status.php:66 Reply

    it isn't strictly, since getLL() has no hard return type set, which is why incomplete tests tend to return null here. no idea why phpstorm says grey "obsolete" string cast here ...
  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/23/21, 22:14

  5. Stefan Bürk commented on patch set 1 10/23/21, 22:15

    Typo3Status.php:66 Reply

    Done
  6. core-ci voted on patch set 1 V +1 10/23/21, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18473

  7. Simon Gilli voted on patch set 1 V +1 CR +1 10/23/21, 22:17

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/21, 22:41

  9. Christian Kuhn merged patch set 2 10/23/21, 22:41