Review main Merged

71954[BUGFIX] Deprecation free \ArrayAccess and \Iterator in QueryResult

Stefan Bürk CR +2 V +2 Easy +24 −0 updated 10/24/21, 15:46

Commit message

Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase QueryResult to
avoid deprecation messages without breaking compatibility.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Stefan Bürk uploaded patch set 1 10/23/21, 22:42

  2. core-ci voted on patch set 1 V +1 10/23/21, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18476

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/23/21, 23:03

  4. Stefan Bürk uploaded patch set 2 10/24/21, 10:35

  5. core-ci voted on patch set 2 V +1 10/24/21, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18488

  6. Christian Kuhn uploaded patch set 3 10/24/21, 15:31

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/24/21, 15:31

  8. core-ci voted on patch set 3 V +1 10/24/21, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18501

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 10/24/21, 15:46

  10. Christian Kuhn merged patch set 4 10/24/21, 15:46