Review 10.4 Merged

71956[BUGFIX] Update composer dev dependencies to min required versions

Andreas Kienast CR +2 V +2 Normal +58 −58 updated 10/25/21, 13:05

Commit message

phpunit released new versions for 8.5.x and 9.5.x, which
no longer automatically throw exception for user deprecations.
Furthermore there was a patch which needs to have
'phpspec/prophecy' on ^1.14.0 as minimum requirement.

This patch increase the min version of the two dev dependencies.
The patch is not strictly needed in 10.4 and was mitigated with
other changes in testing-framework already, but it doesn't hurt
to have this in 10.4 to better align with v11.

Used composer commands:

composer req --dev --with-dependencies phpunit/phpunit:^8.5.21
composer req --dev phpspec/prophecy:^1.14.0

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1419

  1. Andreas Kienast uploaded patch set 1 10/24/21, 09:05

  2. core-ci voted on patch set 1 V -1 10/24/21, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18483

  3. Andreas Kienast uploaded patch set 2 10/24/21, 09:17

  4. core-ci voted on patch set 2 V +1 10/24/21, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18485

  5. Stefan Bürk commented on patch set 2 10/24/21, 09:43

  6. Stefan Bürk commented on patch set 2 CR -1 10/24/21, 09:45

    Waiting for nightly ;)
  7. Oliver Klee voted on patch set 2 CR +1 10/24/21, 10:19

  8. core-ci commented on patch set 2 10/24/21, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18487

  9. Stefan Bürk commented on patch set 2 V +1 CR +1 10/24/21, 10:29

    Nightly green
  10. Wouter Wolters commented on patch set 2 10/25/21, 09:56

    multiple typo's here
  11. Christian Kuhn updated the commit message in patch set 3 10/25/21, 10:12

  12. Christian Kuhn updated the commit message in patch set 4 10/25/21, 10:17

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 10/25/21, 10:17

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 10/25/21, 10:19

  15. Oliver Klee voted on patch set 4 CR +1 10/25/21, 10:24

  16. core-ci voted on patch set 3 V +1 10/25/21, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18523

  17. core-ci voted on patch set 4 V +1 10/25/21, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18524

  18. Christian Kuhn commented on patch set 4 V +2 CR +2 10/25/21, 13:05

    Reply

    Done
  19. Christian Kuhn merged patch set 5 10/25/21, 13:05