Review main Merged

71958[BUGFIX] Deprecation free \Countable in AbstractCompositeValidator

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 10/24/21, 16:46

Commit message

Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in AbstractCompositeValidator
to avoid deprecation messages without breaking compatibility.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 10/24/21, 10:38

  2. core-ci voted on patch set 1 V +1 10/24/21, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18489

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/24/21, 16:44

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 10/24/21, 16:46

  5. Christian Kuhn merged patch set 2 10/24/21, 16:46