Review main Merged

71959[BUGFIX] Deprecation free \ArrayAccess in FormRuntime

Stefan Bürk CR +2 V +2 Easy +9 −3 updated 10/24/21, 17:16

Commit message

Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:form FormRuntime
to avoid deprecation messages without breaking compatibility.

We can however set some of the return values for @internal
marked methods.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 10/24/21, 10:41

  2. core-ci voted on patch set 1 V +1 10/24/21, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18490

  3. Christian Kuhn uploaded patch set 2 10/24/21, 16:57

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/24/21, 16:58

  5. Jochen Roth voted on patch set 2 V +1 CR +1 10/24/21, 17:01

  6. core-ci voted on patch set 2 V +1 10/24/21, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18505

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/24/21, 17:16

  8. Christian Kuhn merged patch set 3 10/24/21, 17:16