Review main Merged

71961[BUGFIX] Deprecation free interfaces in FinisherVariableProvider

Stefan Bürk CR +2 V +2 Easy +10 −4 updated 10/24/21, 17:42

Commit message

Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in FinisherVariableProvider
to avoid deprecation messages without breaking compatibility.
Do that for 'mixed' returns, and use correct return types
directly for this @internal final class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Stefan Bürk uploaded patch set 1 10/24/21, 10:45

  2. core-ci voted on patch set 1 V +1 10/24/21, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18492

  3. Christian Kuhn commented on patch set 1 10/24/21, 17:00

    we can be a bit more aggressive here with that @internal final class
  4. Stefan Bürk commented on patch set 1 10/24/21, 17:05

    Reply

    Partly, yes. but the mixed things will remain for v12 as mixed is min req php8.0.
  5. Christian Kuhn commented on patch set 1 10/24/21, 17:13

    Reply

    yeah.
  6. Christian Kuhn uploaded patch set 2 10/24/21, 17:21

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/24/21, 17:21

  8. core-ci voted on patch set 2 V +1 10/24/21, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18507

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 10/24/21, 17:42

  10. Christian Kuhn merged patch set 3 10/24/21, 17:42

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 10/24/21, 17:42