Review main Merged

71962[BUGFIX] Deprecation free \ArrayAccess in LinkResult

Stefan Bürk CR +2 V +2 Easy +7 −0 updated 10/24/21, 17:04

Commit message

Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:frontend LinkResult
to avoid deprecation messages without breaking compatibility.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/24/21, 10:48

  2. core-ci voted on patch set 1 V +1 10/24/21, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18493

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/24/21, 16:53

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 10/24/21, 17:04

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/24/21, 17:04

  6. Christian Kuhn merged patch set 2 10/24/21, 17:04