Review main Merged

71964[BUGFIX] Suppress deprecation in EmptyFileSearchResult

Nikita Hovratov CR +2 V +2 Easy +4 −0 updated 10/24/21, 17:11

Commit message

Since PHP 8.1 The Countable interface has tentative
return types. This means mismatching return types
trigger deprecation notices. The methods current
and key of EmptyFileSearchResult have the mismatching
return type void. To suppress the deprecation
without a breaking change, the #[\ReturnTypeWillChange]
attribute has been added to those methods.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Nikita Hovratov uploaded patch set 1 10/24/21, 16:38

  2. Nikita Hovratov updated the commit message in patch set 2 10/24/21, 16:39

  3. core-ci voted on patch set 2 V +1 10/24/21, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18504

  4. core-ci voted on patch set 1 V +1 10/24/21, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18503

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/24/21, 17:11

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/24/21, 17:11

  7. Anja Leichsenring merged patch set 3 10/24/21, 17:11