Review main Merged

71967[BUGFIX] Avoid calling strlen(null) in FrontendUserAuthentication

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/25/21, 17:50

Commit message

GeneralUtility::_POST($this->formfield_permanent) returns
null if that field is not set in $_POST. Feeding null
to strlen() emits a E_DEPRECATED PHP 8.1 error. Sanitize
that call.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/25/21, 10:07

  2. Oliver Klee voted on patch set 1 CR +1 10/25/21, 10:12

  3. core-ci voted on patch set 1 V +1 10/25/21, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18522

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/25/21, 11:12

  5. Jochen Roth voted on patch set 1 V +1 CR +1 10/25/21, 15:40

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/25/21, 17:50

  7. Anja Leichsenring merged patch set 2 10/25/21, 17:50