Review main Merged

71970[BUGFIX] Avoid implicit conversion to int in StringUtility

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/25/21, 17:53

Commit message

StringUtility::multibyteStringPad() does a happy division
feeding str_repeat() to evenly pad on left and right side.

The division result can be a float. With PHP 8.1,
str_repeat($string, float) emits E_DEPRECATED
"Implicit conversion from float looses precision.".

Avoid this with an explicit cast.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/25/21, 15:24

  2. core-ci voted on patch set 1 V +1 10/25/21, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18541

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/25/21, 15:50

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/25/21, 17:53

  5. Anja Leichsenring merged patch set 2 10/25/21, 17:53