Review main Merged

71974[BUGFIX] Enforce $GLOBALS['LANG']->sL() returns string

Christian Kuhn CR +2 V +2 Normal +44 −32 updated 10/26/21, 08:09

Commit message

Calling LanguageService->sL() should *always* return
a string, even if it's empty. The patch enforces this.

This reveals a couple of incomplete unit test mocks,
which are fixed to keep the test suite happy.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/25/21, 21:02

  2. Christian Kuhn updated the commit message in patch set 2 10/25/21, 21:03

  3. core-ci voted on patch set 1 V +1 10/25/21, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18558

  4. core-ci voted on patch set 2 V +1 10/25/21, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18559

  5. Benni Mack voted on patch set 2 V +1 CR +1 10/26/21, 07:21

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/26/21, 08:09

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/26/21, 08:09

  8. Christian Kuhn merged patch set 3 10/26/21, 08:09