Review main Abandoned

71979[BUGFIX] Prevent undefined key warning in ConfigurationManager

Robert Kärner CR 0 V 0 Easy +1 −1 updated 10/26/21, 16:08

Commit message

ConfigurationManager might get called outside
of an Extbase plugin, so access to array keys
'extensionName' and 'pluginName' must be
protected with valid fallbacks.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Robert Kärner uploaded patch set 1 10/26/21, 12:27

  2. core-ci voted on patch set 1 V +1 10/26/21, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18571

  3. Nikita Hovratov commented on patch set 1 10/26/21, 16:00

  4. Robert Kärner commented on patch set 1 10/26/21, 16:08

    Reply

    You are right. I'm sure I pulled the latest master today, and the fix wasn't included. Maybe I'm getting insane. I will abandon this patch. Thanks for letting me know.
  5. Robert Kärner abandoned the change 10/26/21, 16:08

    Duplicate of #71843