Review main Merged

71983[BUGFIX] Avoid coalescence to null for string expecting functions

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 10/26/21, 18:42

Commit message

Various functions expect string arguments and emit
E_DEPRECATED with PHP 8.1 in non strict_types=1
calls. The patch adjusts some null coalescence
fallbacks from null to string to satisfy this.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/26/21, 17:56

  2. Jochen Roth voted on patch set 1 V +1 CR +1 10/26/21, 18:16

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/21, 18:18

  4. core-ci voted on patch set 1 V +1 10/26/21, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18578

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/26/21, 18:42

  6. Anja Leichsenring merged patch set 2 10/26/21, 18:42