Review main Merged

71984[BUGFIX] Avoid calling trim(null) in PageRenderer

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 10/26/21, 18:46

Commit message

PageRender sanitizes array values in two methods, using
array walk with trim(). These values can be other
types then string, which trigger deprecation warning in
PHP 8.1.

This patch change the array walk to an closure to have
an explicit type cast to string for passing the value
to trim().

Additional a return type ': string' is added to the
protected method getTemplate(), as this method always
returns a string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Stefan Bürk uploaded patch set 1 10/26/21, 18:03

  2. Christian Kuhn updated the commit message in patch set 2 10/26/21, 18:05

  3. core-ci voted on patch set 1 V +1 10/26/21, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18579

  4. core-ci voted on patch set 2 V +1 10/26/21, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18580

  5. Jochen Roth voted on patch set 2 V +1 CR +1 10/26/21, 18:29

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 10/26/21, 18:46

  7. Christian Kuhn merged patch set 3 10/26/21, 18:46